logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt Sicker (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LOG4J2-708) Servlet filter claims to support async but doesn't use AsyncContext
Date Fri, 11 Jul 2014 01:46:06 GMT

    [ https://issues.apache.org/jira/browse/LOG4J2-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14058211#comment-14058211
] 

Matt Sicker commented on LOG4J2-708:
------------------------------------

Actually, now that I look deeper at this, I don't see a point in having a Filter in async
mode. All the filter does is set the current thread's LoggerContext, and that doesn't make
much sense in an asynchronous context. The LoggerContext is already stored in the ServletContext.
I mean if anything, it could also be added to the ServletRequest attributes for convenience.

> Servlet filter claims to support async but doesn't use AsyncContext
> -------------------------------------------------------------------
>
>                 Key: LOG4J2-708
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-708
>             Project: Log4j 2
>          Issue Type: Bug
>    Affects Versions: 2.0-rc2
>         Environment: Servlet 3.0 (Tomcat 7, Jetty 8) or higher
>            Reporter: Matt Sicker
>            Assignee: Matt Sicker
>
> In log4j-web, when the ServletContainerInitializer adds the Log4j Filter, it sets the
asyncSupported property to true. However, it's still a synchronous Filter.
> A separate asynchronous Filter should be made for Servlet 3.x support that doesn't break
Servlet 2.x.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


Mime
View raw message