logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt Sicker (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LOG4J2-741) Reinstate the package attribute for discovering custom plugins
Date Fri, 25 Jul 2014 17:04:39 GMT

    [ https://issues.apache.org/jira/browse/LOG4J2-741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14074584#comment-14074584
] 

Matt Sicker commented on LOG4J2-741:
------------------------------------

I agree on reverting. I'll help review. We can work on cleaning up duplicate code into proper
abstractions later on. There was some similar duplication I wanted to handle anyway, so adding
in runtime plugin scanning is not a big deal. The plugin processor and runtime version will
just need to be refactored later.

I tested out your patch last night and it seemed to work, but I don't have any Scala plugins
to test it with.

> Reinstate the package attribute for discovering custom plugins
> --------------------------------------------------------------
>
>                 Key: LOG4J2-741
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-741
>             Project: Log4j 2
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 2.0, 2.0-rc2
>            Reporter: Remko Popma
>            Assignee: Matt Sicker
>            Priority: Blocker
>             Fix For: 2.0.1
>
>         Attachments: LOG4J2-741-patch.txt
>
>
> Several people reported problems with their custom plugins no longer being recognized
by log4j2. See LOG4J2-673 and [this StackOverflow question|http://stackoverflow.com/questions/24918810/log4j2-configuration-will-not-load-custom-pattern-converter].
> Plugins created before the annotation processor was added to log4j2 (all plugins created
with 2.0-rc1 and earlier) may not have a {{META-INF/org/apache/logging/log4j/core/config/plugins/Log4j2Plugins.dat}}
file.
> Previously plugins without this metadata file could still be found if the user specified
their custom plugin package(s) in the {{packages}} attribute of the {{<Configuration>}}
element in their log4j2.xml configuration file.
> However, since 2.0-rc2, the {{packages}} configuration attribute was disabled; users
may still specify a value, but log4j2 will no longer use this value to try to load custom
plugins. This causes problems for custom plugins built before the annotation processor was
added to log4j2, as well as custom plugins that are built in an environment where the annotation
processor does not work (for example, most IDEs require some setting changes to enable annotation
processing).
> This Jira ticket is to reactivate the packages configuration attribute. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


Mime
View raw message