logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Remko Popma (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (LOG4J2-812) Performance optimization: avoid use of synchronized SimpleDateFormat in Dat​ePatternCo​nverter
Date Sun, 05 Jul 2015 14:58:04 GMT

     [ https://issues.apache.org/jira/browse/LOG4J2-812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Remko Popma updated LOG4J2-812:
    Attachment: LOG4J2-812-patch.txt

Attached LOG4J2-812-patch.txt introduces a new SoftThreadLocal class with unit test and uses
this class in DatePatternConverter to eliminate the need for a synchronized block.


> Performance optimization: avoid use of synchronized SimpleDateFormat in Dat​ePatternCo​nverter

> -----------------------------------------------------------------------------------------------
>                 Key: LOG4J2-812
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-812
>             Project: Log4j 2
>          Issue Type: Bug
>          Components: Pattern Converters, Performance Benchmarks
>    Affects Versions: 2.0.2
>            Reporter: Mohit Anchlia
>            Assignee: Remko Popma
>             Fix For: 2.3
>         Attachments: LOG4J2-812-patch.txt
> Threads seem to be blocking on class org.apache​.loggin.lo​g4j.core.p​attern.Dat​ePatternCo​nverter.
It's short lived but is visible in profiler. It also is adding on to CPU. Here is the mail
conversation on the mailing list:
> {quote}
> Ralph Goers ralph.goers@dslextreme.com via logging.apache.org  
> The converter uses a SimpleDateFormat which is not thread safe and so is synchronized.
I am sure there might be minor optimizations that could be done to this
>  What I would do is modify DatePatternConverter to
>  a) use Java 8’s java.time.format.DateTimeFormatter if running on Java 8
>  b) use Joda Time’s DateTimeFormat if it is present.
>  c) create a pool of SimpleDateFormat objects and use those.
>  Please create a Jira issue for this.
>  Ralph
> {quote}
> ----
> One alternative that  was suggested on the mailing list is to use commons lang FastDateFormat
to format log timestamps.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org

View raw message