logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: SocketAppender.createAppender() and Protocol Enum
Date Tue, 03 Nov 2015 02:47:00 GMT
Sure, that's easy.

Gary
On Nov 2, 2015 6:39 PM, "Remko Popma" <remko.popma@gmail.com> wrote:

> Okay. Can you leave the existing method in place and add a new one with
> the desired signature?
>
> Sent from my iPhone
>
> On 2015/11/03, at 9:57, Gary Gregory <garydgregory@gmail.com> wrote:
>
> On Mon, Nov 2, 2015 at 3:53 PM, Remko Popma <remko.popma@gmail.com> wrote:
>
>> What would be the advantage of doing this? What problem are you trying to
>> solve by replacing the string arg with an enumeration arg?
>
>
> Is that a trick question? ;-) Type safety from my call site, of course!
>
> Gary
>
>
>>
>> On Monday, November 2, 2015, Gary Gregory <garydgregory@gmail.com> wrote:
>>
>>> Hi All:
>>>
>>> Right now, SocketAppender.createAppender() takes protocol String. Can we
>>> change that to a Protocol Enum safely, without breaking existing configs?
>>> That would break BC unless we add another method.
>>>
>>> Thoughts?
>>>
>>> Gary
>>>
>>> --
>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>> Java Persistence with Hibernate, Second Edition
>>> <http://www.manning.com/bauer3/>
>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>> Spring Batch in Action <http://www.manning.com/templier/>
>>> Blog: http://garygregory.wordpress.com
>>> Home: http://garygregory.com/
>>> Tweet! http://twitter.com/GaryGregory
>>>
>>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
>

Mime
View raw message