logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matt Sicker <boa...@gmail.com>
Subject Re: Advice on package for Encoder and ByteBufferDestination
Date Mon, 04 Apr 2016 17:36:49 GMT
I would imagine most people extend from AbstractLayout or
AbstractStringLayout if they even make custom layouts.

On 4 April 2016 at 12:31, Gary Gregory <garydgregory@gmail.com> wrote:

> And I imagine that _moving_ Layout is too much of a BC break even though
> it is in Core?
>
> Gary
>
> On Sun, Apr 3, 2016 at 10:40 AM, Gary Gregory <garydgregory@gmail.com>
> wrote:
>
>> IMO, the oddness is that Layout is NOT in the layout package. So I would
>> leave all layout items in layout...
>>
>> Gary
>>
>> On Sun, Apr 3, 2016 at 8:00 AM, Remko Popma <remko.popma@gmail.com>
>> wrote:
>>
>>> What package should the Encoder and ByteBufferDestination interfaces
>>> live in?
>>>
>>> Currently they are both in org.apache.logging.log4j.core.layout, but
>>> o.a.l.l.core.Layout extends Encoder and it seems a bit strange to have
>>> Layout's super interface live in a subpackage.
>>>
>>> I think there are pros and cons to leaving them in the layout package or
>>> pulling them up to the core package, but I'd be interested to hear
>>> everyone's feedback.
>>>
>>> Remko
>>>
>>
>>
>>
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> Java Persistence with Hibernate, Second Edition
>> <http://www.manning.com/bauer3/>
>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>> Spring Batch in Action <http://www.manning.com/templier/>
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>>
>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>



-- 
Matt Sicker <boards@gmail.com>

Mime
View raw message