logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Gregory (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LOG4J2-1323) Remove Final Declarations on Many Classes/Methods
Date Sun, 03 Apr 2016 02:49:25 GMT

    [ https://issues.apache.org/jira/browse/LOG4J2-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15223108#comment-15223108
] 

Gary Gregory commented on LOG4J2-1323:
--------------------------------------

Hi Andrew,

I'm somewhat reluctant to open up RollingFileManager even more than it is now. This is mostly
to give us the flexibility to rework this class as we see fit without worrying about compatibility.


For the Core module (unlike the API module), where RollingFileManager resides, we make no
guarantee of backward compatibility from one release to the next. So I would be worried that
making the core even more open would open us up to complaints in the future like "I subclassed
this and that and with the new release, it breaks completely, or there is some subtle behavior
change, please change it back".

I'm curious to see what others think on this one. 

Gary


> Remove Final Declarations on Many Classes/Methods
> -------------------------------------------------
>
>                 Key: LOG4J2-1323
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-1323
>             Project: Log4j 2
>          Issue Type: Wish
>          Components: API, Appenders, Pattern Converters
>    Affects Versions: 2.5
>            Reporter: Andrew Bernhagen
>              Labels: architecture, easyfix, newbie, patch
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Within my organization, I've had to develop a custom appender that automatically configures
certain properties and a specific layout to tie into other initiatives we have tied to logging.
 Log4j2 made this much more difficult than Log4j1 due to the use of final on many classes
(e.g. the appender implementations) and methods (all pattern layout methods).  This has made
extension overly difficult and filled with a lot of copy and paste that I'd rather not have.
 Is it possible that these could be removed to make it easier to extend the existing implementations?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


Mime
View raw message