logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Gregory (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LOG4J2-1348) AutoCloseable ThreadContext access
Date Sun, 03 Apr 2016 02:28:25 GMT

    [ https://issues.apache.org/jira/browse/LOG4J2-1348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15223105#comment-15223105
] 

Gary Gregory commented on LOG4J2-1348:
--------------------------------------

Ok, I see. I like the idea that you can undo your changes all at once by calling close() or,
in your case, using a try-with-resources block.

Feel free to provide a patch with unit tests.

> AutoCloseable ThreadContext access
> ----------------------------------
>
>                 Key: LOG4J2-1348
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-1348
>             Project: Log4j 2
>          Issue Type: Improvement
>          Components: API
>    Affects Versions: 2.5
>            Reporter: Greg Thomas
>            Priority: Minor
>
> The log4j2 API provides a ThreadContext - https://logging.apache.org/log4j/2.x/manual/thread-context.html
-  that allows items to be added to a stack or a map for logging, and then subsequently removed
once they are no longer required.
> This sounds like an ideal candidate for a AutoCloseable implementation so that items
are removed automatically and no longer left around littering the stack/map.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


Mime
View raw message