logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ralph Goers (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LOG4J2-1348) Add an AutoCloseable ThreadContext class: CloseableThreadContext
Date Sat, 16 Apr 2016 17:28:25 GMT

    [ https://issues.apache.org/jira/browse/LOG4J2-1348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15244316#comment-15244316

Ralph Goers commented on LOG4J2-1348:

I don't think I understand why there the "with" or "also" methods are even required. Why can't
you just do:
CloseableThreadContext.put(key, value).put(anotherKey, anotherValue);

That seems more "normal" and obvious to me.

> Add an AutoCloseable ThreadContext class: CloseableThreadContext
> ----------------------------------------------------------------
>                 Key: LOG4J2-1348
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-1348
>             Project: Log4j 2
>          Issue Type: Improvement
>          Components: API
>            Reporter: Greg Thomas
>            Assignee: Gary Gregory
>            Priority: Minor
>             Fix For: 2.6
>         Attachments: CloseableThreadContext.zip, ctc-also.patch, ctc.patch, thread-context.xml.patch
> The log4j2 API provides a ThreadContext - https://logging.apache.org/log4j/2.x/manual/thread-context.html
-  that allows items to be added to a stack or a map for logging, and then subsequently removed
once they are no longer required.
> This sounds like an ideal candidate for a AutoCloseable implementation so that items
are removed automatically and no longer left around littering the stack/map.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org

View raw message