logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ralph Goers (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LOG4J2-1353) Logger 'Object... params' arguments should always be appended even if {} is missing
Date Tue, 05 Apr 2016 17:39:25 GMT

    [ https://issues.apache.org/jira/browse/LOG4J2-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15226729#comment-15226729

Ralph Goers commented on LOG4J2-1353:

That is probably true, especially since the Parameterized format is the only thing SLF4J supports.
 That said, I'm still not convinced that modifying ParameterizedMessage is the way to go.
But this would definitely be applicable to FormattedMessage. If you allow it on ParameterizedMessage
why wouldn't it apply to MessageFormatMessage and StringFormattedMessage?

> Logger 'Object... params' arguments should always be appended even if {} is missing
> -----------------------------------------------------------------------------------
>                 Key: LOG4J2-1353
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-1353
>             Project: Log4j 2
>          Issue Type: New Feature
>          Components: API
>    Affects Versions: 2.5
>            Reporter: Alex Berg
>            Priority: Minor
> The Logger.warn/info/trace etc. has methods that take ... object list. It maps into message
where {} is given. If there are fewer {} than arguments in list, it ignores argument. Who
would ever desire to have an argument ignored? That is to me clearly a bug in the design,
but of cause I may be missing something.
> I suggest to always append the unmatched extra arguments and separate them by a space
or a comma. I'm not sure if the last argument is logged as an exception if it is an exception,
in that case the solution should gracefully handle that.
> A super nice feature would be if it was possible to configure the append of the unmatched
arguments, but I think that is more work than it is worth.
> see http://logging.apache.org/log4j/2.x/log4j-api/apidocs/index.html

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org

View raw message