logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Remko Popma <remko.po...@gmail.com>
Subject Re: [jira] [Commented] (LOG4J2-1549) AsyncLoggerContextSelector+PropertiesConfigurationBuilder defaults to includeLocation=true
Date Thu, 25 Aug 2016 12:47:14 GMT
Good stuff!
FYI, your reply is not visible on the Jira. 

Sent from my iPhone

> On 2016/08/25, at 16:53, Mikael Ståldal <mikael.staldal@magine.com> wrote:
> 
> Or rather, I fixed it for ConfigurationBuilder. I haven't tested if that fixes it for
PropertiesConfigurationBuilder as well, but I guess it will.
> 
>> On Thu, Aug 25, 2016 at 9:52 AM, Mikael Ståldal <mikael.staldal@magine.com>
wrote:
>> Yes. The fix is already in master branch.
>> 
>>> On Thu, Aug 25, 2016 at 6:16 AM, Remko Popma (JIRA) <jira@apache.org> wrote:
>>> 
>>>     [ https://issues.apache.org/jira/browse/LOG4J2-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15436260#comment-15436260
]
>>> 
>>> Remko Popma commented on LOG4J2-1549:
>>> -------------------------------------
>>> 
>>> I think Mikael fixed this recently in LOG4J2-1528.
>>> 
>>> > AsyncLoggerContextSelector+PropertiesConfigurationBuilder defaults to includeLocation=true
>>> > ------------------------------------------------------------------------------------------
>>> >
>>> >                 Key: LOG4J2-1549
>>> >                 URL: https://issues.apache.org/jira/browse/LOG4J2-1549
>>> >             Project: Log4j 2
>>> >          Issue Type: Bug
>>> >          Components: Configurators
>>> >            Reporter: Jason Bedard
>>> >
>>> > The async documentation seems to indicate that includeLocation=false by
default for [async loggers/appenders|https://logging.apache.org/log4j/2.x/manual/async.html#Location]
and for the [all-async|https://logging.apache.org/log4j/2.x/manual/async.html#AllAsync]
>>> > When using properties files PropertiesConfigurationBuilder seems to default
to includeLocation=true for the [root logger|https://git-wip-us.apache.org/repos/asf?p=logging-log4j2.git;a=blob;f=log4j-core/src/main/java/org/apache/logging/log4j/core/config/properties/PropertiesConfigurationBuilder.java;h=0f159ff3d33f638333e8ca530844d81437db99b5;hb=a493c04c046763140612307400f9189d8f0acd28#l299]
and [loggers|https://git-wip-us.apache.org/repos/asf?p=logging-log4j2.git;a=blob;f=log4j-core/src/main/java/org/apache/logging/log4j/core/config/properties/PropertiesConfigurationBuilder.java;h=0f159ff3d33f638333e8ca530844d81437db99b5;hb=a493c04c046763140612307400f9189d8f0acd28#l265],
unless the logger/appender has type=asyncLogger/Appender or you manually specify includeLocation.
>>> > I assume this is specific to properties config but haven't verified that.
>>> > Currently using the latest log4j (2.6.2).
>>> > Side note: I'm using my own ConfigurationFactory, but it just delegates
to PropertiesConfigurationFactory which uses PropertiesConfigurationBuilder. I don't think
this should effect anything.
>>> 
>>> 
>>> 
>>> --
>>> This message was sent by Atlassian JIRA
>>> (v6.3.4#6332)
>>> 
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
>>> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>> 
>> 
>> 
>> -- 
>>  
>> 
>> Mikael Ståldal
>> Senior software developer 
>> 
>> Magine TV
>> mikael.staldal@magine.com    
>> Grev Turegatan 3  | 114 46 Stockholm, Sweden  |   www.magine.com 
>> 
>> Privileged and/or Confidential Information may be contained in this message. If you
are not the addressee indicated in this message
>> (or responsible for delivery of the message to such a person), you may not copy or
deliver this message to anyone. In such case, 
>> you should destroy this message and kindly notify the sender by reply email.   
> 
> 
> 
> -- 
>  
> 
> Mikael Ståldal
> Senior software developer 
> 
> Magine TV
> mikael.staldal@magine.com    
> Grev Turegatan 3  | 114 46 Stockholm, Sweden  |   www.magine.com             
> 
> Privileged and/or Confidential Information may be contained in this message. If you are
not the addressee indicated in this message
> (or responsible for delivery of the message to such a person), you may not copy or deliver
this message to anyone. In such case, 
> you should destroy this message and kindly notify the sender by reply email.   

Mime
View raw message