logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Remko Popma <remko.po...@gmail.com>
Subject Re: logging-log4j2 git commit: [LOG4J2-1501] FileAppender should be able to create files lazily.
Date Fri, 19 Aug 2016 22:53:41 GMT
Gary, looks good. 
The attribute itself is still called lazyCreate, I agree with your Jira comment that createOnDemand
communicates the intent better. 

Sent from my iPhone

> On 2016/08/20, at 1:27, Gary Gregory <garydgregory@gmail.com> wrote:
> 
>> On Fri, Aug 19, 2016 at 9:12 AM, Remko Popma <remko.popma@gmail.com> wrote:
>> Maybe even explain what on demand means in this context: the file is not created
until a log event passes all filters and is routed to this appender.
> 
> Hi Remko,
> 
> Thank you for the feedback. Please review my change based on you comment.
> 
> Gary
>> 
>> Sent from my iPhone
>> 
>> > On 2016/08/20, at 0:57, ggregory@apache.org wrote:
>> >
>> > Repository: logging-log4j2
>> > Updated Branches:
>> >  refs/heads/master 20cff4f80 -> 212c5a4a6
>> >
>> >
>> > [LOG4J2-1501] FileAppender should be able to create files lazily.
>> >
>> > Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
>> > Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/212c5a4a
>> > Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/212c5a4a
>> > Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/212c5a4a
>> >
>> > Branch: refs/heads/master
>> > Commit: 212c5a4a6f02364e0cb380b50d193800523c8cd6
>> > Parents: 20cff4f
>> > Author: Gary Gregory <ggregory@apache.org>
>> > Authored: Fri Aug 19 08:57:27 2016 -0700
>> > Committer: Gary Gregory <ggregory@apache.org>
>> > Committed: Fri Aug 19 08:57:27 2016 -0700
>> >
>> > ----------------------------------------------------------------------
>> > src/site/xdoc/manual/appenders.xml | 5 +++++
>> > 1 file changed, 5 insertions(+)
>> > ----------------------------------------------------------------------
>> >
>> >
>> > http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/212c5a4a/src/site/xdoc/manual/appenders.xml
>> > ----------------------------------------------------------------------
>> > diff --git a/src/site/xdoc/manual/appenders.xml b/src/site/xdoc/manual/appenders.xml
>> > index 51caab6..149c5b0 100644
>> > --- a/src/site/xdoc/manual/appenders.xml
>> > +++ b/src/site/xdoc/manual/appenders.xml
>> > @@ -384,6 +384,11 @@
>> >                 of "%m%n" will be used.</td>
>> >             </tr>
>> >             <tr>
>> > +              <td>lazyCreate</td>
>> > +              <td>boolean</td>
>> > +              <td>The appender creates the file on-demand.</td>
>> > +            </tr>
>> > +            <tr>
>> >               <td>locking</td>
>> >               <td>boolean</td>
>> >               <td>When set to true, I/O operations will occur only while
the file lock is held allowing FileAppenders
>> >
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
>> For additional commands, e-mail: log4j-dev-help@logging.apache.org
> 
> 
> 
> -- 
> E-Mail: garydgregory@gmail.com | ggregory@apache.org 
> Java Persistence with Hibernate, Second Edition
> JUnit in Action, Second Edition
> Spring Batch in Action
> Blog: http://garygregory.wordpress.com 
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory

Mime
View raw message