logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mikael Ståldal (JIRA) <j...@apache.org>
Subject [jira] [Commented] (LOG4J2-1593) Concrete Filter implementations should override equals and hashCode
Date Mon, 19 Sep 2016 08:44:20 GMT

    [ https://issues.apache.org/jira/browse/LOG4J2-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15502737#comment-15502737

Mikael Ståldal commented on LOG4J2-1593:

OK, given the current implementation of the filter framework, it seems to be necessary. Just
make sure to document that third-party Filters need to do it.

> Concrete Filter implementations should override equals and hashCode
> -------------------------------------------------------------------
>                 Key: LOG4J2-1593
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-1593
>             Project: Log4j 2
>          Issue Type: Improvement
>          Components: Filters
>            Reporter: Remko Popma
>             Fix For: 2.8
> For {{CompositeFilter.remove(Filter)}} to work correctly, concrete Filter implementations
should override {{equals}} and {{hashCode}}. 
> This is because CompositeFilter uses List.remove(Object), comparing by equality. Applications
that keep a reference to the Filter object that was registered will work, but for example
registering and unregistering serialized and deserialized instances via JMX will not work
without this.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org

View raw message