logging-log4j-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: Move org.apache.logging.log4j.util.LoaderUtil.isClassAvailable(String) to Core?
Date Wed, 07 Sep 2016 02:08:25 GMT
Hm, that methods depends on the package private class LowLevelLogUtil. So
moving the method to Core would mean making LowLevelLogUtil public. I'm not
sure that's a good tradeoff...

Gary

On Tue, Sep 6, 2016 at 7:44 PM, Remko Popma <remko.popma@gmail.com> wrote:

> Ah! I didn't look at the code. If there's no risk of breaking user code I
> have no objection.
>
> Apologies.
>
> Sent from my iPhone
>
> > On 2016/09/07, at 8:11, Gary Gregory <garydgregory@gmail.com> wrote:
> >
> > How could moving an API marked @since 2.7 break user code?
> >
> > Gary
> >
> >> On Tue, Sep 6, 2016 at 6:34 PM, Remko Popma <remko.popma@gmail.com>
> wrote:
> >>
> >> Is there a problem that needs solving here?
> >> I know we consider the API module's util package private, but I really
> >> don't like making changes that could break user code for no good
> reason...
> >>
> >> Sent from my iPhone
> >>
> >>> On 2016/09/07, at 6:36, Matt Sicker <boards@gmail.com> wrote:
> >>>
> >>> Might as well. If we need it in api, we can move it back later.
> >>>
> >>>> On 6 September 2016 at 15:54, Gary Gregory <garydgregory@gmail.com>
> >> wrote:
> >>>>
> >>>> The API module method
> >>>> org.apache.logging.log4j.util.LoaderUtil.isClassAvailable(String) is
> >>>> @since
> >>>> 2.7 and is only called from the Core module. I propose we move it to
> >> Core.
> >>>>
> >>>> Gary
> >>>>
> >>>> --
> >>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> >>>> Java Persistence with Hibernate, Second Edition
> >>>> <http://www.manning.com/bauer3/>
> >>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> >>>> Spring Batch in Action <http://www.manning.com/templier/>
> >>>> Blog: http://garygregory.wordpress.com
> >>>> Home: http://garygregory.com/
> >>>> Tweet! http://twitter.com/GaryGregory
> >>>
> >>>
> >>>
> >>> --
> >>> Matt Sicker <boards@gmail.com>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: log4j-user-unsubscribe@logging.apache.org
> >> For additional commands, e-mail: log4j-user-help@logging.apache.org
> >
> >
> > --
> > E-Mail: garydgregory@gmail.com | ggregory@apache.org
> > Java Persistence with Hibernate, Second Edition
> > <http://www.manning.com/bauer3/>
> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> > Spring Batch in Action <http://www.manning.com/templier/>
> > Blog: http://garygregory.wordpress.com
> > Home: http://garygregory.com/
> > Tweet! http://twitter.com/GaryGregory
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: log4j-user-unsubscribe@logging.apache.org
> For additional commands, e-mail: log4j-user-help@logging.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message