logging-log4j-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: Trailing space on loglevel in properties file not trimmed
Date Tue, 25 Apr 2017 19:04:55 GMT
It's free and when Jenkins bogs down, Travis is there, building with a
bunch of JDKs. Also the integration with Coveralls is neat, kinda ;-) but
I'm not sure we have that turned on. I know I enabled it for a couple of
Commons components.

Maybe one day Apache will not have to spend time and money in CI...

Gary

On Apr 25, 2017 11:23 AM, "Ralph Goers" <ralph.goers@dslextreme.com> wrote:

> Why do we have something running there?
>
> Ralph
>
> > On Apr 25, 2017, at 11:01 AM, Matt Sicker <boards@gmail.com> wrote:
> >
> > It's the .travis.yml file. Not much we can configure outside the file
> > without Infra getting involved. Docs: <
> > https://docs.travis-ci.com/user/languages/java/>. Doesn't seem like they
> > support Java 9 at the moment.
> >
> > On 25 April 2017 at 11:47, Ralph Goers <ralph.goers@dslextreme.com>
> wrote:
> >
> >> I’ve never looked at the Travis build. I don’t even know where it is
> >> running.  It certainly isn’t configured for Java 9.
> >>
> >> Ralph
> >>
> >>> On Apr 25, 2017, at 7:10 AM, Matt Sicker <boards@gmail.com> wrote:
> >>>
> >>> Might be because we never updated the travis config after adding java 9
> >>> support. Not even sure what to do there, but it's probably not too
> hard.
> >>>
> >>> On 25 April 2017 at 08:59, Michael Lück <michael.lueck@hm-ag.de>
> wrote:
> >>>
> >>>> It's not failing locally but the build on travis-ci is failing:
> >>>> https://travis-ci.org/apache/logging-log4j2/builds/225522713
> >>>>
> >>>> Seems like a broken build running mvn clean install locally runs fine
> >> ...
> >>>>
> >>>> -----Ursprüngliche Nachricht-----
> >>>> Von: Ralph Goers [mailto:ralph.goers@dslextreme.com]
> >>>> Gesendet: Dienstag, 25. April 2017 15:57
> >>>> An: Log4J Users List <log4j-user@logging.apache.org>
> >>>> Betreff: Re: Trailing space on loglevel in properties file not trimmed
> >>>>
> >>>> How is it failing? Do you have Java 9 installed with toolchains
> >> configured?
> >>>>
> >>>> Ralph
> >>>>
> >>>>> On Apr 25, 2017, at 6:46 AM, Michael Lück <michael.lueck@hm-ag.de>
> >>>> wrote:
> >>>>>
> >>>>> Pull request is submitted but the build process seems buggy as my
PR
> >>>>> is not the only one failing currently
> >>>>>
> >>>>> https://github.com/apache/logging-log4j2/pull/75
> >>>>>
> >>>>>
> >>>>> -----Ursprüngliche Nachricht-----
> >>>>> Von: Michael Lück [mailto:michael.lueck@hm-ag.de]
> >>>>> Gesendet: Montag, 24. April 2017 14:59
> >>>>> An: 'Log4J Users List' <log4j-user@logging.apache.org>
> >>>>> Betreff: AW: AW: Trailing space on loglevel in properties file not
> >>>>> trimmed
> >>>>>
> >>>>> Of course ...
> >>>>>
> >>>>> -----Ursprüngliche Nachricht-----
> >>>>> Von: Remko Popma [mailto:remko.popma@gmail.com]
> >>>>> Gesendet: Montag, 24. April 2017 14:57
> >>>>> An: Log4J Users List <log4j-user@logging.apache.org>
> >>>>> Betreff: Re: AW: Trailing space on loglevel in properties file not
> >>>>> trimmed
> >>>>>
> >>>>> Makes sense.
> >>>>> Do you feel like submitting a patch or a pull request?
> >>>>>
> >>>>> (Shameless plug) Every main() method deserves http://picocli.info
> >>>>>
> >>>>>> On Apr 24, 2017, at 21:41, Michael Lück <michael.lueck@hm-ag.de>
> >> wrote:
> >>>>>>
> >>>>>> Yes you're right. Java.util.Properties work this way. But I
think
> the
> >>>> application that uses such properties should still validate the input.
> >> An
> >>>> because the levels are a fixed set of values it would be good to trim
> >> them
> >>>> after reading and before initializing the logger with the value.
> >>>>>>
> >>>>>> -----Ursprüngliche Nachricht-----
> >>>>>> Von: Remko Popma [mailto:remko.popma@gmail.com]
> >>>>>> Gesendet: Montag, 24. April 2017 14:38
> >>>>>> An: Log4J Users List <log4j-user@logging.apache.org>
> >>>>>> Betreff: Re: Trailing space on loglevel in properties file not
> >>>>>> trimmed
> >>>>>>
> >>>>>> I believe that's how java.util.Properties work but I can imagine
> this
> >>>> can be surprising...
> >>>>>>
> >>>>>> Remko
> >>>>>>
> >>>>>> (Shameless plug) Every main() method deserves http://picocli.info
> >>>>>>
> >>>>>>> On Apr 24, 2017, at 21:24, Michael Lück <michael.lueck@hm-ag.de>
> >>>> wrote:
> >>>>>>>
> >>>>>>> Hello all,
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>> I just realised that a trailing space on a level configuration
in a
> >>>>>>> properties file doesn’t change the level of the logger.
> >>>>>>>
> >>>>>>> I created a small example project
> >>>>>>> https://github.com/thuri/log4j-trailing-space-loglevel-properties
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>> While the root logger is initialized with level info I want
to make
> >>>>>>> the custom logger for package com.github.thuri to log on
level
> debug.
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>> When the level definition is written as
> >>>>>>>
> >>>>>>> „logger.logtest.level =  DEBUG “
> >>>>>>>
> >>>>>>> No Debug level logs occur on console
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>> When using
> >>>>>>>
> >>>>>>> “logger.logtest.level =  DEBUG”
> >>>>>>>
> >>>>>>> It works as expected.
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>> Should it really work this way or is this a bug?
> >>>>>>>
> >>>>>>
> >>>>>> ------------------------------------------------------------
> ---------
> >>>>>> To unsubscribe, e-mail: log4j-user-unsubscribe@logging.apache.org
> >>>>>> For additional commands, e-mail: log4j-user-help@logging.apache.org
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>> ------------------------------------------------------------
> ---------
> >>>>>> To unsubscribe, e-mail: log4j-user-unsubscribe@logging.apache.org
> >>>>>> For additional commands, e-mail: log4j-user-help@logging.apache.org
> >>>>>>
> >>>>>
> >>>>> ------------------------------------------------------------
> ---------
> >>>>> To unsubscribe, e-mail: log4j-user-unsubscribe@logging.apache.org
> >>>>> For additional commands, e-mail: log4j-user-help@logging.apache.org
> >>>>>
> >>>>>
> >>>>>
> >>>>> ------------------------------------------------------------
> ---------
> >>>>> To unsubscribe, e-mail: log4j-user-unsubscribe@logging.apache.org
> >>>>> For additional commands, e-mail: log4j-user-help@logging.apache.org
> >>>>>
> >>>>>
> >>>>>
> >>>>> ------------------------------------------------------------
> ---------
> >>>>> To unsubscribe, e-mail: log4j-user-unsubscribe@logging.apache.org
> >>>>> For additional commands, e-mail: log4j-user-help@logging.apache.org
> >>>>>
> >>>>>
> >>>>
> >>>>
> >>>>
> >>>> ---------------------------------------------------------------------
> >>>> To unsubscribe, e-mail: log4j-user-unsubscribe@logging.apache.org
> >>>> For additional commands, e-mail: log4j-user-help@logging.apache.org
> >>>>
> >>>>
> >>>>
> >>>> ---------------------------------------------------------------------
> >>>> To unsubscribe, e-mail: log4j-user-unsubscribe@logging.apache.org
> >>>> For additional commands, e-mail: log4j-user-help@logging.apache.org
> >>>>
> >>>>
> >>>
> >>>
> >>> --
> >>> Matt Sicker <boards@gmail.com>
> >>
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: log4j-user-unsubscribe@logging.apache.org
> >> For additional commands, e-mail: log4j-user-help@logging.apache.org
> >>
> >>
> >
> >
> > --
> > Matt Sicker <boards@gmail.com>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: log4j-user-unsubscribe@logging.apache.org
> For additional commands, e-mail: log4j-user-help@logging.apache.org
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message