lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Erik Hatcher <>
Subject Re: Question about PorterStemFilter class
Date Thu, 04 Nov 2004 09:40:28 GMT
Dr. Porter even recommends going to Snowball, so we should probably  
deprecate PorterStemFilter in favor of Snowball.  I've just added this  
as an item on the Lucene2Whiteboard wiki page.

However, so as to not lose your changes - feel free to add them to a  
Bugzilla issue so that your code can stick around in case anyone else  
is interested in picking it up.


On Nov 4, 2004, at 3:58 AM, Murray Altheim wrote:

> Brian Goetz wrote:
>> The original (Porter) version did indeed not correspond to any  
>> current Java coding standards -- because (a) it was translated to  
>> Java before such standards emerged (JDK 1.0) and (b) translated from  
>> another language.  I left these as is, rather than attempt to clean  
>> them up.
>>> Yes, I understand that. In looking at the code it is quite obviously
>>> of the same origin (i.e. from Martin Porter) but may be an older
>>> version (I couldn't quite tell). It doesn't come close to any normal
>>> Java programming guidelines, and while I didn't try to modify the
>>> latest version so that it would, entirely, because part of the
>>> reason I think whoever wrote the original code formatted it the way
>>> they did was to enable an easier reading of the comparison strings.
>>> I've tried to come to some compromise, as well as (as I mentioned)
>>> predeclaring the Strings so that the VM isn't constantly recreating
>>> them.
> Brian,
> Thanks -- understood (both messages). With code as complicated to
> read as the PorterStemmer, I can understand the reasons. In the
> end, is there any desire for me to post the updated class I've
> created, or should I assume that it will be deprecated in favour
> of the Snowball code? If there's no need for my version, I'm
> fine with that, I just wouldn't want to dump it for no reason,
> nor push insertion of it into Lucene against anyone's wishes.
> Cheers,
> Murray
> ......................................................................
> Murray Altheim          
> Knowledge Media Institute
> The Open University, Milton Keynes, Bucks, MK7 6AA, UK               .
>   The Rise of Pseudo Fascism -- David Neiwert
>   Part 1: The Morphing of the Conservative Movement
> 2004_09_19_dneiwert_archive.html#109028353137888956
>   Part 2: The Architecture of Fascism
> 2004_09_26_dneiwert_archive.html#109563628314780505
>   Part 3: The Pseudo-Fascist Campaign
> 2004_10_03_dneiwert_archive.html#109596147171278590
>   Part 4: The Apocalyptic One-Party State
> 2004_10_10_dneiwert_archive.html#109694976530359103
>   Part 5: Warfare By Other Means
> 2004_10_17_dneiwert_archive.html#109755467135245579
>   Part 6: Breaking Down the Barriers
> 2004_10_24_dneiwert_archive.html#109858062597237163
>   Part 7: It Can Happen Here
> 2004_10_31_dneiwert_archive.html#109902109250035295
> ---------------------------------------------------------------------
> To unsubscribe, e-mail:
> For additional commands, e-mail:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message