lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yonik Seeley (JIRA)" <>
Subject [jira] Created: (LUCENE-438) add Token.setTermText(), remove final
Date Thu, 22 Sep 2005 20:46:27 GMT
add Token.setTermText(), remove final

         Key: LUCENE-438
     Project: Lucene - Java
        Type: Improvement
    Versions: CVS Nightly - Specify date in submission    
    Reporter: Yonik Seeley
    Priority: Minor

The Token class should be more friendly to classes not in it's package:
  1) add setTermText()
  2) remove final from class and toString()
  3) add clone()

Support for (1):
  TokenFilters in the same package as Token are able to do things like 
   "t.termText = t.termText.toLowerCase();" which is more efficient, but more importantly
less error prone.  Without the ability to change *only* the term text, a new Token must be
created, and one must remember to set all the properties correctly.  This exact issue caused
this bug:

Support for (2):
  Removing final allows one to subclass Token.  I didn't see any performance impact after
removing final.
I can go into more detail on why I want to subclass Token if anyone is interested.

Support for (3):
  - support for a synonym TokenFilter, where one needs to make two tokens from one (same args
that support (1), and esp important if instance is a subclass of Token).

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message