lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Lukas Zapletal <lukas.zaple...@linuxexpres.cz>
Subject Re: [jira] Updated: (LUCENE-435) [PATCH] BufferedIndexOutput - optimized writeBytes() method
Date Fri, 16 Dec 2005 09:31:42 GMT
Dne Sun, 11 Dec 2005 17:51:08 +0100 (CET)
"Lukas Zapletal (JIRA)" <jira@apache.org> napsal(a):

> I have done what you requested (sorry for the late delay - too busy). I also found a
bug in RAMOutputStream - the implementation of flushBuffer method was not able to write any
buffers longer than 2*BUFFER_LENGTH. My fast writeBytes patch now handle all various situation
and uses the fastest methods to write data.
> 
> In my opinion its not good to make BUFFER_LENGTH constant public. Consider making it
private since this can lead to nontrivial "dependency" (as I have described above). Its not
good to have one buffer length for input, output and RAM* objects (which should have independant
buffer length at all - it has nothing to do with the caching in the abstract methods). Making
it private and maybe accessible on runtime could help a litte (as I said -- I use the API
for some index copying and I would like to have larger buffers).
> 
> Anyway, this is my contribution, I am looking for more reviews. The patch includes StoreTest
modification which helps with testing either writeByte method or writeBytes methods. Thanks
for your attention.

Hello, no one interested?

I would be pleased if you look at it and comment it. I think its
perfect now.

-- 
S pozdravem / Best regards
Lukas Zapletal
sefredaktor / Editor-In-Chief
LinuxEXPRES - opravdovy linuxovy magazin
www.LinuxEXPRES.cz tel.: +420 777 003 843


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message