lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DM Smith <dmsmith...@gmail.com>
Subject Re: [jira] Commented: (LUCENE-486) Core Test should not have dependencies on the Demo code
Date Wed, 11 Jan 2006 17:26:03 GMT
I have a principle that I code by:
    The Principle of Least Surprise - Write code in such a way that it 
minimize surprises.

It is surprising to me that test cases would have a dependency on demo 
code. IMHO, the dependency should be removed.

Yesterday I installed lucene from jpackage using yum. It also installed 
lucene-demos as that was a dependency. This made no sense to me and 
probably is a problem in the jpackage RPM and not here. But perhaps it 
is a side effect of this issue.

Erik Hatcher (JIRA) wrote:

>    [ http://issues.apache.org/jira/browse/LUCENE-486?page=comments#action_12362429 ]

>
>Erik Hatcher commented on LUCENE-486:
>-------------------------------------
>
>I concur with Grant on this - the dependency from test to demo has caused me annoyance
as well.   I'm in favor of a fix to it, but haven't looked at Grant's solution yet.
>
>  
>
>>Core Test should not have dependencies on the Demo code
>>-------------------------------------------------------
>>
>>         Key: LUCENE-486
>>         URL: http://issues.apache.org/jira/browse/LUCENE-486
>>     Project: Lucene - Java
>>        Type: Test
>>    Versions: 1.4
>>    Reporter: Grant Ingersoll
>>    Priority: Minor
>> Attachments: FileDocument.java, testdoc.patch
>>
>>The TestDoc.java Test file has a dependency on the Demo FileDocument code.  Some of
us don't keep the Demo code around after downloading, so this breaks the build.
>>Patch will be along shortly
>>    
>>
>
>  
>

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message