lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yonik Seeley (JIRA)" <>
Subject [jira] Commented: (LUCENE-818) IndexWriter should detect when it's used after being closed
Date Fri, 02 Mar 2007 19:16:50 GMT


Yonik Seeley commented on LUCENE-818:

I think that accessing a closed reader should continue to be undefined.
If we define it to throw an exception, then we have thread safety issues which would be too
costly (IMO) to fix.

If we are to add checks for a closed reader, it seems like they should only be put on methods
where an additional method call would be negligible.  Hand-holding that decreases performance
for everyone isn't something I like.  Sun often goes too far in this regard, and as a consequence,
people end up rewriting their own version of classes to get better performance.

After all, this is really just making nicer error messages for incorrect programs, right?
 Everyone shouldn't have to pay for that.  I guess I'm a minimalist :-)

> IndexWriter should detect when it's used after being closed
> -----------------------------------------------------------
>                 Key: LUCENE-818
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Index
>    Affects Versions: 2.1
>            Reporter: Michael McCandless
>         Assigned To: Michael McCandless
>            Priority: Minor
>         Attachments: LUCENE-818.patch, LUCENE-818.take2.patch
> Spinoff from this thread on java-user:
> If you call addDocument on IndexWriter after it's closed you'll hit a
> hard-to-explain NullPointerException (because the RAMDirectory was
> closed).  Before 2.1, apparently you won't hit any exception and the
> IndexWrite will keep running but will have released it's write lock (I
> think).
> I plan to fix IndexWriter methods to throw an IllegalStateException if
> it has been closed.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message