lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yonik Seeley (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1050) SimpleFSLockFactory ignores error on deleting the lock file
Date Thu, 17 Jan 2008 04:34:35 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12559803#action_12559803
] 

Yonik Seeley commented on LUCENE-1050:
--------------------------------------

FYI, I just verified that Solr does this correctly for the main index (since we'll be upgrading
lucene versions soon)
{code}
        if (IndexReader.isLocked(dir)) {
          log.warning(logid+"WARNING: Solr index directory '" + getIndexDir() + "' is locked.
 Unlocking...");
          IndexReader.unlock(dir);
        }
{code}


> SimpleFSLockFactory ignores error on deleting the lock file
> -----------------------------------------------------------
>
>                 Key: LUCENE-1050
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1050
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Store
>    Affects Versions: 2.2
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>            Priority: Minor
>             Fix For: 2.3
>
>         Attachments: LUCENE-1050.patch
>
>
> Spinoff from here:
>     http://www.gossamer-threads.com/lists/lucene/java-user/54438
> The Lock.release for SimpleFSLockFactory ignores the return value of lockFile.delete().
 I plan to throw a new LockReleaseFailedException, subclassing from IOException, when this
returns false.  This is a very minor change to backwards compatibility because all methods
in Lucene that release a lock already throw IOException.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message