lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doron Cohen (JIRA)" <>
Subject [jira] Commented: (LUCENE-1112) Document is partially indexed on an unhandled exception
Date Tue, 01 Jan 2008 22:28:43 GMT


Doron Cohen commented on LUCENE-1112:

I skimmed at the long token part of the patch:
* In the test, why is the position increment of 'another' 3, 
  I think it should be 2?
* assertEquals("failed document should not be in the index",2,reader.numDocs());
  should be "document with skipped token should be in the index"?
* I believe that "positon++" in DocumentsWriter is not required because 
  invertField() already incremented the position before calling addPosition()?
  (my fault, I suggested to still increment the position...)

> Document is partially indexed on an unhandled exception
> -------------------------------------------------------
>                 Key: LUCENE-1112
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Index
>    Affects Versions: 2.3
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>            Priority: Minor
>             Fix For: 2.3
>         Attachments: lucene-1112-test.patch, LUCENE-1112.patch
> With LUCENE-843, it's now possible for a subset of a document's
> fields/terms to be indexed or stored when an exception is hit.  This
> was not the case in the past (it was "all or none").
> I plan to make it "all or none" again by immediately marking a
> document as deleted if any exception is hit while indexing it.
> Discussion leading up to this:

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message