lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <>
Subject [jira] Commented: (LUCENE-1335) Correctly handle concurrent calls to addIndexes, optimize, commit
Date Mon, 25 Aug 2008 21:31:44 GMT


Michael McCandless commented on LUCENE-1335:

> I don't think so: with autoCommit=true, the merges calls commit(long)
> after finishing, and I think we want those commit calls to run
> concurrently?

After we disable autoCommit, all commit calls will be serialized, right?


Back to the issue of running an external merge in BG or FG.
In ConcurrentMergeScheduler.merge, an external merge is run in FG,
not in BG. But in,
whether a merge is external is no longer checked. Why this difference?
Good point!  We no longer need to check for isExternal in CMS's merge() method -- we can run
all merges in the BG.  In fact I think it's no longer necessary to even compute & record
isExternal (this was its only use).  Hmmm, except when I take this out I'm seeing testAddIndexOnDiskFull
hang.  I'll dig.

> Correctly handle concurrent calls to addIndexes, optimize, commit
> -----------------------------------------------------------------
>                 Key: LUCENE-1335
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Index
>    Affects Versions: 2.3, 2.3.1
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>            Priority: Minor
>             Fix For: 2.4
>         Attachments: LUCENE-1335.patch, LUCENE-1335.patch, LUCENE-1335.patch, LUCENE-1335.patch
> Spinoff from here:

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message