lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "DM Smith (JIRA)" <>
Subject [jira] Updated: (LUCENE-1350) Filters which are "consumers" should not reset the payload or flags and should better reuse the token
Date Fri, 08 Aug 2008 20:45:44 GMT


DM Smith updated LUCENE-1350:

    Attachment: LUCENE-1350.patch

Should we just absorb this issue into LUCENE-1333? DM, of your list
above (of filters that lose payload), are there any that are not fixed
in LUCENE-1333? I'm confused on the overlap and it's hard to work
with all the patches. Actually if in LUCENE-1333 you could
consolidate down to a single patch (big toplevel "svn diff"), that'd
be great

LUCENE-1333 will have to include all of this. I have already created a patch for LUCENE-1350
and LUCENE-1333, which satisfies this requirement. If LUCENE-1350 goes first, then the patch
for LUCENE-1333 will need to be re-built. If LUCENE-1333 goes first then this one can be closed.

I really don't care which is done first. If both are going to be in the next release, then
I think just do LUCENE-1333. But if for some reason, we are going to do a release before 2.4
and only LUCENE-1350 is going in it, then that's fine with me.

As to the effort I have already done the work. And I was happy to do it :)

> Filters which are "consumers" should not reset the payload or flags and should better
reuse the token
> -----------------------------------------------------------------------------------------------------
>                 Key: LUCENE-1350
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Analysis, contrib/*
>            Reporter: Doron Cohen
>            Assignee: Doron Cohen
>             Fix For: 2.3.3
>         Attachments: LUCENE-1350.patch, LUCENE-1350.patch
> Passing tokens with payloads through SnowballFilter results in tokens with no payloads.
> A workaround for this is to apply stemming first and only then run whatever logic creates
the payload, but this is not always convenient.
> Other "consumer" filters have similar problem.
> These filters can - and should - reuse the token, by implementing next(Token), effectively
also fixing the unwanted resetting.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message