lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <>
Subject [jira] Resolved: (LUCENE-2104) IndexWriter.unlock does does nothing if NativeFSLockFactory is used
Date Tue, 01 Jun 2010 18:37:38 GMT


Michael McCandless resolved LUCENE-2104.

    Resolution: Fixed

> IndexWriter.unlock does does nothing if NativeFSLockFactory is used
> -------------------------------------------------------------------
>                 Key: LUCENE-2104
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Store
>    Affects Versions: 2.9, 2.9.1, 3.0
>            Reporter: Shai Erera
>            Assignee: Uwe Schindler
>            Priority: Minor
>             Fix For: 2.9.3, 3.0.2, 3.1, 4.0
>         Attachments: LUCENE-2104.patch, LUCENE-2104.patch, LUCENE-2104.patch
> If NativeFSLockFactory is used, IndexWriter.unlock will return, silently doing nothing.
The reason is that NativeFSLockFactory's makeLock always creates a new NativeFSLock. NativeFSLock's
release first checks if its lock is not null. However, only if obtain() is called, that lock
is not null. So release actually does nothing, and so IndexWriter.unlock does not delete the
lock, or fail w/ exception.
> This is only a problem in NativeFSLock, and not in other Lock implementations, at least
as I was able to see.
> Need to think first how to reproduce in a test, and then fix it. I'll work on it.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message