lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Woody Anderson (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2545) improve uses of StringHelper.intern in Field,AbstractField, NumericField etc.
Date Sun, 18 Jul 2010 18:43:49 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889651#action_12889651
] 

Woody Anderson commented on LUCENE-2545:
----------------------------------------

What is the working definition of "outside"?
public methods?
if those internName constructors are protected is that ok?

I dont' know enough about the 4.0 branch yet to comment about how this relates or doesn't,
but for the 3.x branch, when making a lot of fields, and i know they have to be intern'd anyway,
i can and do have strings that are already intern'd. I basically would have to do this anyway,
but given that i can, i intern them with StringHelper and avoid the extra intern in xxxField.
I would like for this to be possible, even if i am using "expert" annotated constructors etc.

I prefer not to write all my code in the lucene.document package in order to use pkg protection,
but I'm sure i can write some helper methods for myself and call from my other code. Would
you be more open to having this kind of exposure limited to package scope?

> improve uses of StringHelper.intern in Field,AbstractField, NumericField etc.
> -----------------------------------------------------------------------------
>
>                 Key: LUCENE-2545
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2545
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Other
>    Affects Versions: 3.0.2
>            Reporter: Woody Anderson
>             Fix For: 3.1, 4.0
>
>         Attachments: LUCENE-2545.patch
>
>
> There are many times for certain field types that intern is still called when it is not
needed. We can improve this with pretty simple open up of the constructors etc.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message