lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-2002) improve build/tests
Date Fri, 16 Jul 2010 21:44:52 GMT

    [ https://issues.apache.org/jira/browse/SOLR-2002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889344#action_12889344
] 

Hoss Man commented on SOLR-2002:
--------------------------------

bq. If you truly believe this (I think you are wrong), then we should do the following:

it's right there in the javadoc for SolrExampleTestBase

{noformat}
 * This should include tests against the example solr config
{noformat}

...it has subclasses that use Jetty, and other subclasses that use embedded solr.

bq. the example config used in said tests shouldnt load up shit from contrib.

the example config is the example config -- it's the config we put up on a pedestal in each
release and say "this is what you should start with when writing your own config".  we should
test that those configs are actually usable w/o errors -- that was the goal of the test

If the example configs suggest loading stuff from contrib, then we need to test that too.

bq. ...if they are really unit tests as you claim...

a) I never claimed they were unit tests ... i called them "tests".  
b) I have no interest in getting into a philosophical debate about unit vs functional vs integration
tests.  
c) I never stated an opinion about whether we need to test the usage of these configs in both
in embedded clients and in jetty.

i didn't write the test, and i didn't defend the use of Jetty for this -- so pick a fight
with someone else if that's your goal.  All i did was point out that changing the test to
use configs different from those in the example directory defeats the point of the tests.



> improve build/tests
> -------------------
>
>                 Key: SOLR-2002
>                 URL: https://issues.apache.org/jira/browse/SOLR-2002
>             Project: Solr
>          Issue Type: Task
>          Components: Build
>            Reporter: Robert Muir
>            Assignee: Robert Muir
>            Priority: Minor
>             Fix For: 3.1, 4.0
>
>         Attachments: SOLR-2002.patch, SOLR-2002_core_contrib.patch, SOLR-2002setupteardown.patch
>
>
> we are working on improving some functionality in lucene's build/tests, it would be good
to improve the solr side to take advantage of it.
> currently its only sorta-kinda integrated and a bit messy.
> i'd like to do some incremental improvements piece-by-piece on this issue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message