lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2235) implement PerFieldAnalyzerWrapper.getOffsetGap
Date Mon, 06 Dec 2010 08:28:13 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12967121#action_12967121
] 

Uwe Schindler commented on LUCENE-2235:
---------------------------------------

To come back to the original issue:

bq. Should this be checking that a field is indeed analyzed before calling getOffsetGap ?

In my opinion this should be done (and so this issue would disappear). Can you open another
issue requesting this check and link it to this one?

One problem coming from not checking for "analyzed" is this:
You add a field indexed and it gets analyzed by PFAW - After that you add the same field name
stored-only (which is perfectly legal and often used, e.g. when the stored value is binary
or in some other format and does not correspond to the indexed text), the positionIncrement
is increased. After that you again add another instance of the same field as indexed-only,
which also increases posIncr. So you have 2 times the gap between both indexed sub-fields.
This is definitely wrong.

> implement PerFieldAnalyzerWrapper.getOffsetGap
> ----------------------------------------------
>
>                 Key: LUCENE-2235
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2235
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Analysis
>    Affects Versions: 3.0
>         Environment: Any
>            Reporter: Javier Godoy
>            Assignee: Uwe Schindler
>            Priority: Minor
>             Fix For: 2.9.4, 3.0.3, 3.1, 4.0
>
>         Attachments: LUCENE-2235.patch, PerFieldAnalyzerWrapper.patch
>
>
> PerFieldAnalyzerWrapper does not delegates calls to getOffsetGap(Fieldable), instead
it returns the default values from the implementation of Analyzer. (Similar to LUCENE-659
"PerFieldAnalyzerWrapper fails to implement getPositionIncrementGap")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message