lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simon Willnauer (JIRA)" <>
Subject [jira] Updated: (LUCENE-2805) SegmentInfos shouldn't blindly increment version on commit
Date Tue, 07 Dec 2010 04:23:09 GMT


Simon Willnauer updated LUCENE-2805:

    Attachment: LUCENE-2805.patch

here is a slightly updated patch that removes the blind increment from DefaultSegmentInfosWriter,
adds #changed() calles to contrib classes and adds a missing #changed() call to IW#deleteAll()

test pass also for LUCENE-2802

> SegmentInfos shouldn't blindly increment version on commit
> ----------------------------------------------------------
>                 Key: LUCENE-2805
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Index
>            Reporter: Michael McCandless
>             Fix For: 3.1, 4.0
>         Attachments: LUCENE-2805.patch, LUCENE-2805.patch
> SegmentInfos currently increments version on the assumption that there are always changes.
> But, both DirReader and IW are more careful about tracking whether there are changes.
 DirReader has hasChanges and IW has changeCount.  I think these classes should notify the
SIS when there are in fact changes; this will fix the case Simon hit on fixing LUCENE-2082
when the NRT reader thought there were changes, but in fact there weren't because IW simply
committed the exact SIS it already had.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message