lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Earwin Burrfoot (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2818) abort() method for IndexOutput
Date Sat, 18 Dec 2010 10:06:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12972765#action_12972765
] 

Earwin Burrfoot commented on LUCENE-2818:
-----------------------------------------

bq. I think we can make a default impl that simply closes & suppresses exceptions? (We
can't .deleteFile since an abstract IO doesn't know its Dir). Our concrete impls can override
w/ versions that do delete the file...
I don't think we need a default impl? For some directory impls close() is a noop + what is
more important, having abstract method forces you to implement it, you can't forget this,
so we're not gonna see broken directories that don't do abort() properly.

> abort() method for IndexOutput
> ------------------------------
>
>                 Key: LUCENE-2818
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2818
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Earwin Burrfoot
>
> I'd like to see abort() method on IndexOutput that silently (no exceptions) closes IO
and then does silent papaDir.deleteFile(this.fileName()).
> This will simplify a bunch of error recovery code for IndexWriter and friends, but constitutes
an API backcompat break.
> What do you think?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message