lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2824) optimizations for bufferedindexinput
Date Sun, 19 Dec 2010 12:05:02 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12972969#action_12972969
] 

Uwe Schindler commented on LUCENE-2824:
---------------------------------------

For the MMap case with *veeeery* large arrays, the cost of exception instantiation with stack
trace is really small. I think for small buffer sizes like 1024 the overhead would be immense.
But we should check this :-)

Another place where the checks were omitted and instead AIOOBE is catched is FieldCacheRangeFilter.
This really helps there! But in that case FieldCache is always large :-)

> optimizations for bufferedindexinput
> ------------------------------------
>
>                 Key: LUCENE-2824
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2824
>             Project: Lucene - Java
>          Issue Type: Improvement
>    Affects Versions: 3.1, 4.0
>            Reporter: Robert Muir
>         Attachments: LUCENE-2824.patch
>
>
> along the same lines as LUCENE-2816:
> * the readVInt/readVLong/readShort/readInt/readLong are not optimal here since they defer
to readByte. for example this means checking the buffer's bounds per-byte in readVint instead
of per-vint.
> * its an easy win to speed this up, even for the vint case: its essentially always faster,
the only slower case is 1024 single-byte vints in a row, in this case we would do a single
extra bounds check (1025 instead of 1024)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message