lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2901) KeywordMarkerFilter resets keyword attribute state to false for tokens not in protwords.txt
Date Sun, 30 Jan 2011 18:09:43 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988622#action_12988622
] 

Robert Muir commented on LUCENE-2901:
-------------------------------------

Simon, i think the key point here is that the code does this:
{noformat}
keywordAtt.setKeyword(keywordSet.contains(word));
{noformat}

I am suggesting this be changed to:
{noformat}
if (keywordSet.contains(word))
  keywordAtt.setKeyword(true);
{noformat}

This is more consistent with what the javadoc says it does: it doesn't speak of unsetting
any attributes.

> KeywordMarkerFilter resets keyword attribute state to false for tokens not in protwords.txt
> -------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-2901
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2901
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Analysis
>    Affects Versions: 3.1
>            Reporter: Drew Farris
>            Assignee: Robert Muir
>            Priority: Minor
>             Fix For: 3.1, 4.0
>
>         Attachments: LUCENE-2901.patch
>
>
> KeywordMarkerFilter sets true or false for the KeywordAttribute on all tokens. This erases
previous state established further up the filter chain, for example in the case where a custom
filter wants to prevent a token from being stemmed. 
> If a token is already marked as a keyword (KeywordAttribute.isKeyword() == true), perhaps
the KeywordMarkerFilterFactory should not re-set the state to false.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message