lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yonik Seeley (JIRA)" <>
Subject [jira] Commented: (LUCENE-2831) Revise Weight#scorer & Filter#getDocIdSet API to pass Readers context
Date Thu, 06 Jan 2011 02:15:45 GMT


Yonik Seeley commented on LUCENE-2831:

>    Should Filter.getDocIDSet take an AtomicReaderContext? We don't have
>    to do that in this patch, though... this patch is a big enough first
>    step!

bq. Yeah I would like to do so, similar to Weight#scorer but currently mainly solr prevents
us from this.

Which part?  I was looking into migrating some SolrIndexSearcher to ReaderContext, and realized
I needed the global base.
I clould walk up to calculate, but then I realized that AtomicReaderContext already has that!
 So we should either change to AtomicReaderContext, or put a getBaseInTop() method on ReaderContext.

> Revise Weight#scorer & Filter#getDocIdSet API to pass Readers context
> ---------------------------------------------------------------------
>                 Key: LUCENE-2831
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Search
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>             Fix For: 4.0
>         Attachments: LUCENE-2831.patch, LUCENE-2831.patch, LUCENE-2831.patch, LUCENE-2831.patch,
LUCENE-2831.patch, LUCENE-2831.patch
> Spinoff from LUCENE-2694 - instead of passing a reader into Weight#scorer(IR, boolean,
boolean) we should / could revise the API and pass in a struct that has parent reader, sub
reader, ord of that sub. The ord mapping plus the context with its parent would make several
issues way easier. See LUCENE-2694, LUCENE-2348 and LUCENE-2829 to name some.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message