lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <>
Subject [jira] Closed: (LUCENE-1949) FilterManager uses unsafe keys for its filter cache
Date Thu, 27 Jan 2011 10:57:47 GMT


Shai Erera closed LUCENE-1949.

    Resolution: Won't Fix

FilterManager is used only by 'remote' classes, which are deprecated in 3x and removed from
trunk. I'm think FilterManager can be deprecated as well. We have CachingWrapperFilter which
caches Filters and is much better.

> FilterManager uses unsafe keys for its filter cache
> ---------------------------------------------------
>                 Key: LUCENE-1949
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Search
>    Affects Versions: 2.9
>            Reporter: Aaron McKee
>            Priority: Minor
> re: FilterManager.getFilter(Filter filter)
> FilterManager is using the filter's hash code as the key to its filter cache, however
hash codes are intrinsically not guaranteed to be distinct; different filters may hash to
the same value. Although the chance of a conflict is hopefully low, given reasonable implementations
of hashCode, it's certainly not impossible. When a conflict does occur, an unintended filter
may be returned.
> I'm unaware to what extent this class is actively being used, but noticed the issue during
a code browse and thought I'd at least mention it. 

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message