lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simon Willnauer (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2101) Default Stopwords should use specific Version in CharArraySet construtor
Date Mon, 03 Jan 2011 11:04:45 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12976696#action_12976696
] 

Simon Willnauer commented on LUCENE-2101:
-----------------------------------------

I think we can simple  move that to v4.0 and v3.1 in  the 3x branch, any objections?

{code}

Index: modules/analysis/common/src/java/org/apache/lucene/analysis/core/StopAnalyzer.java
===================================================================
--- modules/analysis/common/src/java/org/apache/lucene/analysis/core/StopAnalyzer.java	(revision
1052196)
+++ modules/analysis/common/src/java/org/apache/lucene/analysis/core/StopAnalyzer.java	(working
copy)
@@ -58,7 +58,7 @@
       "that", "the", "their", "then", "there", "these",
       "they", "this", "to", "was", "will", "with"
     );
-    final CharArraySet stopSet = new CharArraySet(Version.LUCENE_CURRENT, 
+    final CharArraySet stopSet = new CharArraySet(Version.LUCENE_40, 
         stopWords.size(), false);
     stopSet.addAll(stopWords);  
     ENGLISH_STOP_WORDS_SET = CharArraySet.unmodifiableSet(stopSet); 
{code}



> Default Stopwords should use specific Version in CharArraySet construtor
> ------------------------------------------------------------------------
>
>                 Key: LUCENE-2101
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2101
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/analyzers
>            Reporter: Simon Willnauer
>            Priority: Minor
>             Fix For: 4.0
>
>
> [LUCENE-2094] added a version to the constructor of CharArraySet. The default sets in
*Analyzer uses Version.LUCENE_CURRENT which currently does not do any harm. Yet, in the future
changes to CharArraySet depending on the version could potentially cause index corruption
if those default version are not changed. To make sure such a corruption can not happen the
default sets should use a specific Version (Version.LUCENE_31)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message