lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yonik Seeley (JIRA)" <>
Subject [jira] Updated: (LUCENE-2751) add LuceneTestCase.newSearcher()
Date Sat, 29 Jan 2011 21:58:43 GMT


Yonik Seeley updated LUCENE-2751:

    Attachment: LUCENE-2751.patch

Whew, this code is complex, and I don't really have a solution I like.

Here's a patch to IntValuesCreator that's only for brainstorming purposes...
- synchronize on the entry instead of the creator so more than one segment may be loaded concurrently.
 This is needed to publish objects safely.
- when guessing the parser, don't set it until it succeeds - basically split up setParserAndResetCounts()
to set the counts first, but the parser last.
- when setting/checking the parser, we need to synchronize on the creator

I also just realized that the mere act of checking the cache creates objects (see the base
getCacheKey() ).

> add LuceneTestCase.newSearcher()
> --------------------------------
>                 Key: LUCENE-2751
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Test
>          Components: Build
>            Reporter: Robert Muir
>             Fix For: 4.0
>         Attachments: LUCENE-2751.patch, LUCENE-2751.patch, LUCENE-2751.patch
> Most tests in the search package don't care about what kind of searcher they use.
> we should randomly use MultiSearcher or ParallelMultiSearcher sometimes in tests.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message