lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erick Erickson (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-2303) remove unnecessary (and problematic) log4j jars in contribs
Date Tue, 18 Jan 2011 16:49:43 GMT

    [ https://issues.apache.org/jira/browse/SOLR-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983260#action_12983260
] 

Erick Erickson commented on SOLR-2303:
--------------------------------------

I am Officially Confused, but the culprit appears to be log4j-over-slf4j-1.5.5.jar

3_x has:
   log4j jars in solr/contrib/extraction and solr/contrib/clustering
   a bunch of slf4j jars in solr/lib (but NOT log4j-over-slf4j-1.5.5.jar, see below).
   All tests succeed just fine.

Trunk has:
  no log4j jars in contrib
  the same slf4j jars as in 3_x BUT ALSO log4j-over-slf4j-1.5.5.jar
  VelocityResponseWriterTest fails


In trunk, removing log4j-over-slf4j-1.5.5.jar allows VelocityResponseWriterTest and all other
tests to succeed.

in 3_x, removing the log4j jars from solr/contrib makes no difference, all tests pass.

So I propose that the fix for this is to remove the log4j files from 3_x and the log4j-over-slf4j-1.5.5.jar
from trunk.

Should I create a patch? And do patches actually remove jars like this?

> remove unnecessary (and problematic) log4j jars in contribs
> -----------------------------------------------------------
>
>                 Key: SOLR-2303
>                 URL: https://issues.apache.org/jira/browse/SOLR-2303
>             Project: Solr
>          Issue Type: Improvement
>          Components: Build
>            Reporter: Robert Muir
>             Fix For: 4.0
>
>         Attachments: SOLR-2303.patch
>
>
> In solr 4.0 there is log4j-over-slf4j.
> But if you have log4j jars also in the classpath (e.g. contrib/extraction, contrib/clustering)
you can get strange errors such as:
> java.lang.NoSuchMethodError: org.apache.log4j.Logger.setAdditivity(Z)V
> So I think we should remove the log4j jars in these contribs, all tests pass with them
removed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message