lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2609) Generate jar containing test classes.
Date Thu, 27 Jan 2011 11:55:43 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987514#action_12987514
] 

Shai Erera commented on LUCENE-2609:
------------------------------------

So Robert, I don't really follow the BUILD FAILURE thing - what could fail? Those files are
compiled against the test.classpath so whatever changes you make to test classes, this sample
of files won't be affected at compile time. It's only at runtime, meaning when someone actually
integrating them into his test env. that a problem may be discovered.

If you split LTC to LTC1 and LTC2, then all it means is that LTC won't be included (b/c the
copy task won't find it) and we'll need to fix the testfiles file to include LTC1 and 2.

bq. How about some common courtesy here?

Grant, I didn't mean to hastily commit something in the middle of your night, in order to
slip it through. We did discuss it here and over IRC and it seemed ok to commit. And it was
part of rapid issues solving phase. Sorry if I offended you in any way.

We can jar up all *.java to reduce the file size. I'm not too concerned about the file size
but more of the usability of it. If we're doing some service, then let's do it properly. If
we jar dozens, or tens of dozens of .java files, how will users use the .jar? Vs if we just
jar the relevant classes that make up the framework?

> Generate jar containing test classes.
> -------------------------------------
>
>                 Key: LUCENE-2609
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2609
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: 3.0.2
>            Reporter: Drew Farris
>            Assignee: Shai Erera
>            Priority: Minor
>             Fix For: 3.1, 4.0
>
>         Attachments: LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch
>
>
> The test classes are useful for writing unit tests for code external to the Lucene project.
It would be helpful to build a jar of these classes and publish them as a maven dependency.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message