lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2472) The terms index divisor in IW should be set via IWC not via getReader
Date Tue, 18 Jan 2011 16:33:43 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983252#action_12983252
] 

Michael McCandless commented on LUCENE-2472:
--------------------------------------------

bq. So I guess all that's needed is to deprecate IW.getReader(int) on 3x and remove from trunk?

+1

Though, it's already removed on trunk.  So we just need to deprecate on 3.x...

> The terms index divisor in IW should be set via IWC not via getReader
> ---------------------------------------------------------------------
>
>                 Key: LUCENE-2472
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2472
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 3.1, 4.0
>
>
> The getReader call gives a false sense of security... since if deletions have already
been applied (and IW is pooling) the readers have already been loaded with a divisor of 1.
> Better to set the divisor up front in IWC.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message