lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-2303) remove unnecessary (and problematic) log4j jars in contribs
Date Tue, 18 Jan 2011 17:01:51 GMT

    [ https://issues.apache.org/jira/browse/SOLR-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983265#action_12983265
] 

Robert Muir commented on SOLR-2303:
-----------------------------------

Erick, actually i think the issue is that log4j-over-slf4j conflicts with log4j, if log4j
is in the classpath.

The problem is that currently, the solr build runs tests with whatever is in ant's classpath.
This is why the tests pass for you, even if you remove all logging jars, but this is obviously
bad as its not really a repeatable build.

So to fix this, we need to use includeantruntime=no in the junit tasks, and also not include
$java.class.path in the test classpath.
instead, we explicitly include the ant libs we supply (especially since we extend some of
them for testing).

This might make some warnings or even errors for ant 1.8 users, but I think thats ok.


> remove unnecessary (and problematic) log4j jars in contribs
> -----------------------------------------------------------
>
>                 Key: SOLR-2303
>                 URL: https://issues.apache.org/jira/browse/SOLR-2303
>             Project: Solr
>          Issue Type: Improvement
>          Components: Build
>            Reporter: Robert Muir
>             Fix For: 4.0
>
>         Attachments: SOLR-2303.patch
>
>
> In solr 4.0 there is log4j-over-slf4j.
> But if you have log4j jars also in the classpath (e.g. contrib/extraction, contrib/clustering)
you can get strange errors such as:
> java.lang.NoSuchMethodError: org.apache.log4j.Logger.setAdditivity(Z)V
> So I think we should remove the log4j jars in these contribs, all tests pass with them
removed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message