lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (LUCENE-2822) TimeLimitingCollector starts thread in static {} with no way to stop them
Date Thu, 03 Mar 2011 17:03:37 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13002071#comment-13002071
] 

Uwe Schindler edited comment on LUCENE-2822 at 3/3/11 5:01 PM:
---------------------------------------------------------------

bq. I think we should stick with our private timer thread (and we should definitely make it
stop-able).

I think this is still the best variant, as both System.nanoTime() and currentTimeMillies use
system calls that are really expensive. nanoTime() has no wallclock problems, thats true,
but is still a no-go for every collected hit!

      was (Author: thetaphi):
    bq. I think we should stick with our private timer thread (and we should definitely make
it stop-able).

I think this is still the best reason, as both System.nanoTime() and currentTimeMillies use
system calls that are really expensive. But nanoTime() has no wallclock problems, thats true,
but is still a no-go for every collected hit!
  
> TimeLimitingCollector starts thread in static {} with no way to stop them
> -------------------------------------------------------------------------
>
>                 Key: LUCENE-2822
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2822
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Robert Muir
>
> See the comment in LuceneTestCase.
> If you even do Class.forName("TimeLimitingCollector") it starts up a thread in a static
method, and there isn't a way to kill it.
> This is broken.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message