lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martijn van Groningen (JIRA)" <>
Subject [jira] [Updated] (LUCENE-3099) Grouping module should allow subclasses to set the group key per document
Date Sun, 29 May 2011 20:31:48 GMT


Martijn van Groningen updated LUCENE-3099:

    Attachment: LUCENE-3099.patch

Attached a new patch that is based on Mike's patch.
* All existing grouping tests pass
* AllGroupsCollector has also been included in this infrastructure.

Only the TermSecondPassGroupingCollector didn't work. The size groupDocs array was too small.

I think the following things need to be done:
* Update the documentation in package.html
* Backport to 3x

Should we rename all abstract collectors to Abstract*? To make it clear that these classes
are abstract.

> Grouping module should allow subclasses to set the group key per document
> -------------------------------------------------------------------------
>                 Key: LUCENE-3099
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>             Fix For: 3.2, 4.0
>         Attachments: LUCENE-3099.patch, LUCENE-3099.patch, LUCENE-3099.patch
> The new grouping module can only group by a single-valued indexed field.
> But, if we make the 'getGroupKey' a method that a subclass could override, then I think
we could refactor Solr over to the module, because it could do function queries and normal
queries via subclass (I think).
> This also makes the impl more extensible to apps that might have their own interesting
group values per document.

This message is automatically generated by JIRA.
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message