lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steven Rowe (JIRA)" <>
Subject [jira] [Commented] (SOLR-2537) Refactor Solr modules structure
Date Mon, 23 May 2011 14:52:47 GMT


Steven Rowe commented on SOLR-2537:

bq. Where is this issue going to?  I've provided re-producable steps to a build (bonus!) issue,
and recommended a simplyfing (bonus!) solution.

Gabriele, I downloaded the .zip file you pointed to, and unpacked it, and it's a full Lucene/Solr
source tree, apparently with the changes you want.

When I saw this, I didn't look any further.  I don't want to spend the time it will take to
figure out the differences between what you propose and what currently exists.  The problem
is that performing these comparisons is really time-consuming without tool support.

Please attach a patch to this issue with your changes, along with whatever "svn move", "svn
delete", etc. instructions are required to transform the source, as well as the revision you're
basing it on, so that I can look at the patch, and use my IDE to help me understand what you
are proposing.

Attaching a patch also allows you to indicate acceptance of the Apache Software License for
your contributions.  This is very important.

> Refactor Solr modules structure
> -------------------------------
>                 Key: SOLR-2537
>                 URL:
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Gabriele Kahlout
>            Priority: Minor
>             Fix For: 3.1.1
> Solr modules are nested in a non-standard archeotype (e.g. Solr Core module is in the
src dir of Solr parent).
> Also, a workaround for avoiding maven dependencies between Solr Core and Testframework
makes it impossible to add a depenency on Solr-3.2-SNAPHOST (Solr Search Server) since it's
packaged as a war, to import, for example. It has been discussed on
the mailing list[1].
> I've, in the mlist, suggested to "create yet one more module for Tests which depend on
Solr Core and on the Test Framework. The org burden of that extra module, versus the ease
of building configuration, I believe, outweights."
> However I realize there's a major drawback in that, i.e. that Solr Core will build without
passing the tests in the other module. There're 2 solutions:
> 1. Make Solr Core a parent module that encompasses a thin Solr Core, the TestFramework
module, and the Tests-only module;
> 2. 'Downgrade' Testframework from being a fully-fledged module by moving the packages
under Solr Core. 
> 2a. Move them under Solr Core test packages.
> 2b. move them under Solr Core src
> To me 2a is most intuitive. Those that want a dependency on Solr TestFramework declare
it with <classifier>tests</classifier>, which packages only the tests, and the
Solr Core classes those require.[2][3]
> The same refactoring applies to lucuene.
> [1]
> [2]
> [3] I've successfully used it before.

This message is automatically generated by JIRA.
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message