lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <>
Subject [jira] [Updated] (SOLR-2530) Remove Noggit CharArr from FieldType
Date Sun, 22 May 2011 14:43:47 GMT


Robert Muir updated SOLR-2530:

    Attachment: SOLR-2530.patch

It seems like we can get rid of UTF16Result entirely. I will wait for comments first.


upon review there are two things i dont like:

1. I dont think the BIGTERM should be in UnicodeUtil, its completely unrelated to unicode.
2. I dont like the way UTF8toUTF16 sets the output, i think it should be consistent with UTF16toUTF8
(always make the result output start at 0). The problem can be seen by the size allocation:
    int out_offset = chars.offset;
    final char[] out = chars.chars =  ArrayUtil.grow(chars.chars, out_offset + length);

> Remove Noggit CharArr from FieldType
> ------------------------------------
>                 Key: SOLR-2530
>                 URL:
>             Project: Solr
>          Issue Type: Improvement
>          Components: Schema and Analysis
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>            Priority: Minor
>              Labels: api-change
>             Fix For: 4.0
>         Attachments: SOLR-2530.patch, SOLR-2530.patch, SOLR-2530.patch, SOLR-2530.patch
> FieldType#indexedToReadable(BytesRef, CharArr) uses a noggit dependency that also spreads
into ByteUtils. The uses of this method area all convert to String which makes this extra
reference and the dependency unnecessary. I refactored it to simply return string and removed
ByteUtils entirely. The only leftover from BytesUtils is a constant, i moved that one to Lucenes
UnicodeUtils. I will upload a patch in a second

This message is automatically generated by JIRA.
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message