lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <>
Subject [jira] [Commented] (LUCENE-3099) Grouping module should allow subclasses to set the group key per document
Date Sun, 29 May 2011 17:16:47 GMT


Michael McCandless commented on LUCENE-3099:

That patch is totally untested, and has at least 2 generics
warnings!  But hopefully the approach can work...

Basically the idea of the 2nd patch is to just make minimal extensions
points to the current grouping collectors, so that Solr could subclass
these and use its MutableValue/DocValues to manage the group keys.  I
think this would then mean Solr trunk and Solr 3.x could fully cutover
and not lose any functionality (and gain the benefits of the grouping

Separately, we should merge the cool GroupValue, GroupValueSource,
GroupHolder, etc., from the first patch here, with Solr's equivalents,
factored out I think into a shared "common" module that the FQ module
(LUCENE-2883) can also use.

> Grouping module should allow subclasses to set the group key per document
> -------------------------------------------------------------------------
>                 Key: LUCENE-3099
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>             Fix For: 3.2, 4.0
>         Attachments: LUCENE-3099.patch, LUCENE-3099.patch
> The new grouping module can only group by a single-valued indexed field.
> But, if we make the 'getGroupKey' a method that a subclass could override, then I think
we could refactor Solr over to the module, because it could do function queries and normal
queries via subclass (I think).
> This also makes the impl more extensible to apps that might have their own interesting
group values per document.

This message is automatically generated by JIRA.
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message