lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <>
Subject [jira] [Commented] (SOLR-1804) Upgrade Carrot2 to 3.2.0
Date Fri, 10 Jun 2011 02:46:58 GMT


Robert Muir commented on SOLR-1804:

well it wasnt 'reverted', but in general I think if we can simplify code, we should.

NOTE: my complaint's aren't with Dawid's code, it was easy to see what was going on (though
I did check guava code to make sure it wasnt doing anything really magic behind the scenes,
aka we weren't losing anything)... but again my concern is the more general case, that by
using external libraries like this, it makes it harder for others to work on the code, and
makes us more prone to bugs (e.g. now we have to worry about bugs in guava too, we have a
hard enough time with JRE bugs).

If its truly necessary, e.g. if Guava has a HuperDuper O(1)-for-all-operations datastructure,
then go for it and use it, but if its just a thin veil around what java already provides,
I think we should try to avoid it.

> Upgrade Carrot2 to 3.2.0
> ------------------------
>                 Key: SOLR-1804
>                 URL:
>             Project: Solr
>          Issue Type: Improvement
>          Components: contrib - Clustering
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>             Fix For: 3.1, 4.0
>         Attachments: SOLR-1804-carrot2-3.4.0-dev-trunk.patch, SOLR-1804-carrot2-3.4.0-dev.patch,, SOLR-1804.patch, carrot2-core-3.4.0-jdk1.5.jar
> Carrot2 is now LGPL free, which means we should be able to bundle the binary!

This message is automatically generated by JIRA.
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message