lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Male (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3232) Move MutableValues to Common Module
Date Thu, 23 Jun 2011 04:23:47 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13053642#comment-13053642
] 

Chris Male commented on LUCENE-3232:
------------------------------------

New code to execute with patch:

{code}svn mkdir --parents modules/common/src/java/org/apache/lucene/common/mutable
svn move solr/src/java/org/apache/solr/search/MutableValue.java modules/common/src/java/org/apache/lucene/common/mutable/MutableValue.java
svn move solr/src/java/org/apache/solr/search/MutableValueFloat.java modules/common/src/java/org/apache/lucene/common/mutable/MutableValueFloat.java
svn move solr/src/java/org/apache/solr/search/MutableValueBool.java modules/common/src/java/org/apache/lucene/common/mutable/MutableValueBool.java
svn move solr/src/java/org/apache/solr/search/MutableValueDate.java modules/common/src/java/org/apache/lucene/common/mutable/MutableValueDate.java
svn move solr/src/java/org/apache/solr/search/MutableValueDouble.java modules/common/src/java/org/apache/lucene/common/mutable/MutableValueDouble.java
svn move solr/src/java/org/apache/solr/search/MutableValueInt.java modules/common/src/java/org/apache/lucene/common/mutable/MutableValueInt.java
svn move solr/src/java/org/apache/solr/search/MutableValueLong.java modules/common/src/java/org/apache/lucene/common/mutable/MutableValueLong.java
svn move solr/src/java/org/apache/solr/search/MutableValueStr.java modules/common/src/java/org/apache/lucene/common/mutable/MutableValueStr.java
svn move dev-tools/idea/modules/analysis/common/common.iml dev-tools/idea/modules/analysis/common/analysis-common.iml
{code}

This code includes a change to the common.iml file used by IntelliJ for the Analysis Common
module, since this name clashed.

> Move MutableValues to Common Module
> -----------------------------------
>
>                 Key: LUCENE-3232
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3232
>             Project: Lucene - Java
>          Issue Type: Sub-task
>          Components: core/search
>            Reporter: Chris Male
>             Fix For: 4.0
>
>         Attachments: LUCENE-3232.patch, LUCENE-3232.patch
>
>
> Solr makes use of the MutableValue* series of classes to improve performance of grouping
by FunctionQuery (I think).  As such they are used in ValueSource implementations.  Consequently
we need to move these classes in order to move the ValueSources.
> As Yonik pointed out, these classes have use beyond just FunctionQuerys and might be
used by both Solr and other modules.  However I don't think they belong in Lucene core, since
they aren't really related to search functionality.  Therefore I think we should put them
into a Common module, which can serve as a dependency to Solr and any module.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message