lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Male (JIRA)" <>
Subject [jira] [Commented] (LUCENE-3271) Move 'good' contrib/queries classes to Queries module
Date Sun, 14 Aug 2011 13:47:27 GMT


Chris Male commented on LUCENE-3271:

Command for regex patch:

svn move --parents lucene/contrib/queries/src/java/org/apache/lucene/search/regex/* modules/queries/src/java/org/apache/lucene/queries/regex/
svn move --parents lucene/contrib/queries/src/test/org/apache/lucene/search/regex/* modules/queries/src/test/org/apache/lucene/queries/regex/
svn move --parents lucene/contrib/queries/lib/* modules/queries/lib/
svn delete lucene/contrib/queries/src/test/org/apache/lucene/search/regex
svn delete lucene/contrib/queries/src/java/org/apache/lucene/search/regex

> Move 'good' contrib/queries classes to Queries module
> -----------------------------------------------------
>                 Key: LUCENE-3271
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Chris Male
>         Attachments: LUCENE-3271-MLT.patch, LUCENE-3271-MLT.patch, LUCENE-3271-regex.patch
> With the Queries module now filled with the FunctionQuery stuff, we should look at closing
down contrib/queries.  While not a huge contrib, it contains a number of pretty useful classes
and some that should go elsewhere.
> Heres my proposed plan:
> - similar.* -> suggest module
> - regex.* -> queries module
> - BooleanFilter -> queries module under .filters package
> - BoostingQuery -> queries module
> - ChainedFilter -> queries module under .filters package
> - DuplicateFilter -> queries module under .filters package
> - FieldCacheRewriteMethod -> This doesn't belong in this contrib or the queries module.
 I think we should push it to contrib/misc for the time being.  It seems to have quite a few
constraints on when its useful.  If indeed CONSTANT_SCORE_AUTO rewrite is better, then I dont
see a purpose for it.
> - FilterClause -> class inside BooleanFilter
> - FuzzyLikeThisQuery -> suggest module. This class seems a mess with its Similarity
hardcoded.  With all that said, it does seem to do what it claims and with some cleanup, it
could be good.
> - TermsFilter -> queries module under .filters package
> - SlowCollated* -> They can stay in the module till we have a better place to nuke
> One of the implications of the above moves, is that the xml-query-parser, which supports
many of the queries, will need to have a dependency on the queries module.  But that seems
unavoidable at this stage.

This message is automatically generated by JIRA.
For more information on JIRA, see:


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message