lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erick Erickson (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-2906) Implement LFU Cache
Date Tue, 20 Dec 2011 18:26:31 GMT

    [ https://issues.apache.org/jira/browse/SOLR-2906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173378#comment-13173378
] 

Erick Erickson commented on SOLR-2906:
--------------------------------------

Right, there's a lot of code to wrap your head around and it can be bewildering. And compared
to what you've already done, this is easy....

But lots of things are surprisingly easy in Solr, except when they're not really hard <G>.


This is just about allowing another parameter to be specified in the declaration in solrconfig.xml,
similar to initialSize, autowarmCount, etc. cleanupThread is probably a good exemplar.

Take a look at LFUCache.java.init for how all of the other ones are parsed.

Then just pass that through to the ConcurrentLFUCache, conditionally doing the "ce.hits.set(ce.hitsCopy
>>> 1);" line. Defaulting the timeDecay=true if not present.

So this should be relatively few lines of actual code, making some automated tests will actually
take more time I suspect, as well as any Wiki documentation if you're feeling ambitious....
                
> Implement LFU Cache
> -------------------
>
>                 Key: SOLR-2906
>                 URL: https://issues.apache.org/jira/browse/SOLR-2906
>             Project: Solr
>          Issue Type: Sub-task
>          Components: search
>    Affects Versions: 3.4
>            Reporter: Shawn Heisey
>            Assignee: Erick Erickson
>            Priority: Minor
>         Attachments: ConcurrentLFUCache.java, LFUCache.java, SOLR-2906.patch, SOLR-2906.patch,
SOLR-2906.patch, SOLR-2906.patch, SOLR-2906.patch, TestLFUCache.java
>
>
> Implement an LFU (Least Frequently Used) cache as the first step towards a full ARC cache

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message