lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3672) IndexCommit.equals() bug
Date Tue, 03 Jan 2012 22:32:39 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179084#comment-13179084
] 

Robert Muir commented on LUCENE-3672:
-------------------------------------

its also not ideal and that equals() is inconsistent with compareTo() even if we fixed it
this way, because compareTo() doesn't consider Directory.
                
> IndexCommit.equals() bug
> ------------------------
>
>                 Key: LUCENE-3672
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3672
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: core/index
>    Affects Versions: 4.0
>            Reporter: Andrzej Bialecki 
>
> IndexCommit.equals() checks for equality of Directories and versions, but it doesn't
check IMHO the more important generation numbers. It looks like commits are really identified
by a combination of directory and segments_XXX, which means the generation number, because
that's what the DirectoryReader.open() checks for.
> This bug leads to an unexpected behavior when the only change to be committed is in userData
- we get two commits then that are declared equal, they have the same version but they have
different generation numbers. I have no idea how this situation is treated in a few dozen
references to IndexCommit.equals() across Lucene...
> On the surface the fix is trivial - either add the gen number to equals(), or use gen
number instead of version. However, it's puzzling why these two would ever get out of sync???
and if they are always supposed to be in sync then maybe we don't need both of them at all,
maybe just generation or version is sufficient?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message