lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adrien Grand (JIRA)" <>
Subject [jira] [Commented] (LUCENE-4171) Performance improvements to Packed64
Date Thu, 28 Jun 2012 09:07:44 GMT


Adrien Grand commented on LUCENE-4171:

Patch looks very good, all core tests pass on my computer too. Maybe still two minor things
to fix before commit:
 - you shouldn't override {{getArray}}. This method must return a non-null array only when
the number of bits per value matches the backing array type (some components use it to directly
work with an array instead of a PackedInts.Reader).
 - could you use lower camelCase for instance variables (MASK_LEFT, MASK_RIGHT and BPV_MINUS_BLOCK_SIZE)?
> Performance improvements to Packed64
> ------------------------------------
>                 Key: LUCENE-4171
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Sub-task
>          Components: core/other
>    Affects Versions: 4.0, 5.0
>         Environment: Tested with 4 different Intel machines
>            Reporter: Toke Eskildsen
>            Priority: Minor
>              Labels: performance
>         Attachments: LUCENE-4171.patch
>   Original Estimate: 4h
>  Remaining Estimate: 4h
> Based on the performance measurements of PackedInts.Mutable's in LUCENE-4062, a new version
of Packed64 has been created that is consistently faster than the old Packed64 for both get
and set.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message